fix(amazonq): duplicate messages in flare chat #7097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
justinmk3
approved these changes
Apr 17, 2025
opieter-aws
approved these changes
Apr 17, 2025
Comment on lines
+65
to
+66
| this.webviewView = webviewView | ||
| this.webview = this.webviewView.webview |
Contributor
There was a problem hiding this comment.
That's a lot of views 👀
| : webviewView.webview.asWebviewUri(Uri.parse(path.join(dist.fsPath, source))).toString() | ||
| this.uiPath = webviewView.webview.asWebviewUri(Uri.parse(this.mynahUIPath)).toString() | ||
|
|
||
| webviewView.webview.html = await this.getWebviewContent() |
Contributor
There was a problem hiding this comment.
nit: to make it easier to read/navigate the webviews in this file, consider only using the webview properties you define in line 65-66
Contributor
|
Is there an easy way to add a test case for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
when the flare chat panel refreshes on log in/log out, the message listener never gets disposed of, causing the next webview instantiation to have two message listeners that are forwarding messages to the ui
Solution
dispose of the message listener when the webview gets disposed
feature/xbranches will not be squash-merged at release time.